Revert "constexpr version" #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 46f7838. due to constexpr after every commit the Version.h will change and thus the whole ccache is contaminated as Version.h is included in SGObject.h
gf712
requested changes
Jan 30, 2019
| @@ -35,60 +34,35 @@ class Version | |||
| /** print version */ | |||
| static void print_version(); | |||
|
|
|||
| /** get main version */ | |||
| static constexpr const char* get_version_main() { | |||
There was a problem hiding this comment.
need to keep the equivalent of this
There was a problem hiding this comment.
should be fixed in the commit below...
gf712
approved these changes
Jan 30, 2019
| @@ -54,6 +53,61 @@ void Version::print_version() | |||
| #endif | |||
| } | |||
|
|
|||
| const char* Version::get_version_main() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 46f7838.
due to constexpr after every commit the Version.h will change and thus
the whole ccache is contaminated as Version.h is included in SGObject.h