WIP add uint16 (word) string list to example/test #4540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in/outgoing typemaps for non-char SGStringList
char
, but apparently never tested. Never has worked. Also found this lovely comment/* all (strings) must have same length in octave */
. The new outgoing typemap now returns a cell array of row vectors for non-char types and a cell array of strings for char. Compatible with ingoing typemapfrom the line
32 int[][] word_list = f_word.get_word_string_list("string_list");
which was caused by using the wrong JNI array type inint[][]
, namely[[I]
instead of[I
. Also generally cleaned up the method and fixed a memory leak that was introduced in #4423