factories are factories #4604
Merged
factories are factories #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is an attempt to fix #4321 |
This was referenced Apr 10, 2019
|
erf, seems like it isn't that straightforward... |
|
create_object in |
|
imo that refcount++ inn create_object should be dropped... but i'm gonna test it on donbot |
|
this became a memory leaking cleanup pr |
vigsterkr
commented
Apr 12, 2019
| @@ -21,8 +21,8 @@ combined_kernel.add("kernel_array", k_3) | |||
| #![create_kernels] | |||
|
|
|||
| #![create_classifier] | |||
| SVM libsvm = as_svm(machine("LibSVM")) | |||
| Machine svm = machine("MKLClassification", kernel=combined_kernel, interleaved_optimization=False, svm=libsvm) | |||
| SVM libsvm = machine("LibSVM") | |||
There was a problem hiding this comment.
for some reason if as_svm is being used here the ref counting is broken :S
vigsterkr
commented
Apr 12, 2019
| @@ -25,8 +25,8 @@ combined_kernel.init(features_train, features_train) | |||
| #![create_combined_train] | |||
|
|
|||
| #![train_mkl] | |||
| SVM binary_svm_solver = as_svm(machine("SVRLight")) | |||
| Machine mkl = machine("MKLRegression", svm=binary_svm_solver, kernel=combined_kernel, labels=labels_train) | |||
| SVM binary_svm_solver = machine("SVRLight") | |||
There was a problem hiding this comment.
for some reason if as_svm is being used here the ref counting is broken :S
There was a problem hiding this comment.
broken in which way? too high or too low?
gf712
reviewed
Apr 12, 2019
| @@ -1,3 +1,28 @@ | |||
| %newobject shogun::distance(std::string name); | |||
There was a problem hiding this comment.
doesn't it matter that it is const std::string&?
vigsterkr
force-pushed
the
factory_swig
branch
3 times, most recently
from
1aa6cdf
to
8b6d3ed
Compare
they are always gonna love :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they are always gonna love :)