isfinite for msvc #4612
Merged
isfinite for msvc #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gf712
commented
Apr 17, 2019
| // TODO: microsoft should really start supporting c++11 | ||
| #define IS_FINITE(x) _isfinite(x) | ||
| #else | ||
| #include <cmath> |
There was a problem hiding this comment.
@vigsterkr this should solve your ruby issue
There was a problem hiding this comment.
otherwise you might have to include header at the top of the swig file, like here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::isfinitein msvc only accepts floats (otherwise there is anambiguous call to overloaded functioncompiler error), so need to use_isfinitefrom cfloat to implicitly covert non-floats to floats.