Make GMM model observable. #4652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geektoni
force-pushed
the
feature/observable_GMM
branch
2 times, most recently
from
774c6b6
to
4bbf17d
Compare
geektoni
force-pushed
the
feature/observable_GMM
branch
2 times, most recently
from
13287b8
to
0bf28db
Compare
karlnapf
reviewed
May 31, 2019
| #![create_gmm_instance] | ||
|
|
||
| #![add_observer] | ||
| ParameterObserver obs = parameter_observer("ParameterObserverLogger") |
There was a problem hiding this comment.
as said in my other unrelated comment, it would be good/better if this guy used the mechanics as used in SGObject::to_string()
There was a problem hiding this comment.
I may update it in another PR since I do not want to bloat this one :)
karlnapf
reviewed
May 31, 2019
karlnapf
reviewed
May 31, 2019
karlnapf
reviewed
May 31, 2019
karlnapf
reviewed
May 31, 2019
geektoni
force-pushed
the
feature/observable_framework
branch
from
d21f741
to
bac22e6
Compare
* Emit log-likelihood, alphas and gaussians when using the train_em() method; * Emit log-likelihood, alphas and gaussians when using the train_smem() method; * Change m_coefficients registered name to "coefficients" and fix meta example;
framework. * Update also the associated observe() directives; * Improve GMM observable meta example;
geektoni
force-pushed
the
feature/observable_GMM
branch
from
0bf28db
to
933ff24
Compare
karlnapf
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
train_em()method;train_smem()method;