-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARD and Gradient Search Vector Learning #649
Conversation
Conflicts: src/shogun/evaluation/GradientResult.h src/shogun/kernel/GaussianARDKernel.cpp src/shogun/kernel/LinearARDKernel.cpp src/shogun/kernel/LinearARDKernel.h src/shogun/modelselection/GradientModelSelection.cpp src/shogun/modelselection/ModelSelectionParameters.cpp src/shogun/modelselection/ModelSelectionParameters.h
|
||
using namespace shogun; | ||
|
||
void print_message(FILE* target, const char* str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, if you init shogun with init_with_defaults() you dont need this method, take a look at other examples
1.) I think these checks hurt nobody |
Conflicts: examples/undocumented/libshogun/regression_gaussian_process_ard.cpp src/shogun/evaluation/GradientResult.h src/shogun/kernel/GaussianARDKernel.cpp src/shogun/kernel/GaussianARDKernel.h src/shogun/kernel/LinearARDKernel.cpp src/shogun/kernel/LinearARDKernel.h src/shogun/modelselection/GradientModelSelection.cpp
Okay. Cleaned some stuff up. What do you think? |
ARD and Gradient Search Vector Learning
I think its nice! |
This patch supports Gradient Search on Vector elements. An application is the Linear and
Gaussian ARD Kernels. Results seem to be similar to that of GPML
check if the left and right hand features are NULL, or has that been done already in the superclass?
get_single_combination. However, it doesn't yet through get_combinations, mostly due to point (4) below. Heiko, do you have any suggestions on integrating vectors/sg_vectors for the get_combinations function?