Use CBLAS optimized vector multiplication inside SGVector::vec1_plus_scalar_times_vec2 #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function SGVector::vec1_plus_scalar_times_vec2 maps nicely onto cblas_saxpy and cblas_daxpy, which are significantly faster. Had to disable generic template for vec1_plus_scalar_times_vec2, but it is not used anyway.
lisitsyn
added a commit
that referenced
this pull request
Jul 17, 2012
Use CBLAS optimized vector multiplication inside SGVector::vec1_plus_scalar_times_vec2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function SGVector::vec1_plus_scalar_times_vec2 maps nicely onto
cblas_saxpy and cblas_daxpy, which are significantly faster.
The generic template for vec1_plus_scalar_times_vec2 is commented out, but it is not used anyway. Other (unoptimized) instantiations are trivial to write based on the commented out version, should they be needed in the future.