[666] Python Protocols for DenseFeatures #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gsomix
commented
Jul 20, 2012
gsomix
commented
| data=(char*)arg1->get_feature_matrix(num_feat, num_vec); | ||
|
|
||
| if (ilow<0) | ||
| { |
There was a problem hiding this comment.
something is weir with indention here.
|
Evil #666 PR |
| { | ||
| npy_intp idx; | ||
| idx = PyArray_PyIntAsIntp(item); | ||
| idx = get_idx_in_bounds(idx, length); |
There was a problem hiding this comment.
something is still weird with spaces ... mixture of tabs and whitespaces perhaps?
sonney2k
pushed a commit
that referenced
this pull request
Jul 23, 2012
Python Buffer Protocol support for DenseFeatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.