Relaxed Tree #679
Relaxed Tree #679
Conversation
| @@ -4,7 +4,7 @@ VALGRINDOPTS=--tool=memcheck --error-limit=no --trace-children=yes --leak-check= | |||
|
|
|||
| INCLUDES=-I/usr/include/atlas | |||
| LIBS= | |||
| LIBS_ADD=-lshogun | |||
| LIBS_ADD=-lshogun -lpthread | |||
There was a problem hiding this comment.
why is this needed? if shogun uses pthread related stuff in its header files the correct fix would be to move this code into the corresponding .cpp file
There was a problem hiding this comment.
actually this will cause build errors. I will remove that - please fix your code to work w/o -lpthread here
There was a problem hiding this comment.
Oh, sorry. I remember I fixed this, no idea why it is still there.
There was a problem hiding this comment.
Seems like this was only still visible in the comments but not the code.
Chiyuan Zhang notifications@github.com wrote:
@@ -4,7 +4,7 @@ VALGRINDOPTS=--tool=memcheck --error-limit=no
--trace-children=yes --leak-check=INCLUDES=-I/usr/include/atlas
LIBS=
-LIBS_ADD=-lshogun
+LIBS_ADD=-lshogun -lpthreadOh, sorry. I remember I fixed this, no idea why it is still there.
Reply to this email directly or view it on GitHub:
https://github.com/shogun-toolbox/shogun/pull/679/files#r1328760
Sent from Kaiten Mail. Please excuse my brevity.
|
Hi @sonney2k, Thanks for so many comments. I've fixed most of them, and for those not fixed, I've provided response to your comments. Please review again. |
|
Hi, I switched to using shallow_copy for copying CKernels. |
| /** A shalow copy. | ||
| * All the SGObject instance variables will be simply assigned and SG_REF-ed. | ||
| */ | ||
| virtual CSGObject *shalow_copy() const |
There was a problem hiding this comment.
Hi, I'm sorry for the typo. This is fixed now.
Hi all,
This is the Relaxed Tree Implementation in shogun. I think I finally get it done, please review the code and get it merged. Thanks!