Mountain Lion changed API of scandir #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API of scandir has been changed in OSX 10.8 in a way that it's the same as in other linux distros. Without this fix shogun will not compile on OSX 10.8
| @@ -58,7 +58,12 @@ enum EMessageType | |||
| #define FBUFSIZE 4096 | |||
|
|
|||
| #ifdef DARWIN | |||
| #include <Availability.h> | |||
| #ifdef __MAC_10_8 | |||
There was a problem hiding this comment.
hmmhh can you somehow check for os greater equal 10.8 here? Otherwise we will have the same issue with the next os release.
requested by Soeren
|
this patch should do that |
sonney2k
pushed a commit
that referenced
this pull request
Aug 8, 2012
Mountain Lion changed API of scandir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API of scandir has been changed in OSX 10.8 in a way
that it's the same as in other linux distros. Without this
fix shogun will not compile on OSX 10.8