Fix memory leaks in BMRM and fix the generic risk function #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st time allocation
lisitsyn
added a commit
that referenced
this pull request
Aug 24, 2012
Fix memory leaks in BMRM and fix the generic risk function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This path solve the leaks associated with the use of the BMRM in the example so_multiclass.cpp. It seems that there are still other left triggered by so_multiclass_BMRM.cpp
The two last commits fix the generic risk function. I have compared the results of using CStructuredModel::risk and CMulticlassModel::risk and they are the same! I have also tested python_modular/structure_hmsvm_bmrm and the accuracy result has increased wrt the same test Sergey and I carried out a couple of nights ago.