-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for slash commands and interactive msg #100
Conversation
I'm happy to let this one go forward and redact my proposed PR :) |
I’ve been meaning to review #88 again but have been pulled away by life for
a bit. I’ll check both out this week and see about getting slash command
support merged in.
…On Mon, Mar 28, 2022 at 12:27 Caleb Tennis ***@***.***> wrote:
I'm happy to let this one go forward and redact my proposed PR :)
—
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEJGTNLGLVFG5U74FA2WT3VCIB3BANCNFSM5PQZ56CA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hello @arusso, I hope that everything went great with the review. Is there a way to help move this PR forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission!
Could you provide a minimal example that one can run to exercise the code to go with this?
Once you make the field changes and provide a minimal example we can finally get this merged.
Thanks!
context.go
Outdated
@@ -55,9 +55,15 @@ type MessageEvent struct { | |||
// Channel ID where the message was sent | |||
Channel string | |||
|
|||
// ChannelName where the message was sent | |||
ChannelName func() string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other struct fields are strings, for the sake of consistency ChannelName and UserName should be as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context.go
Outdated
// User ID of the sender | ||
User string | ||
|
||
// UserName of the the sender | ||
UserName func() string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a a string
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The channel name and username is fetch eager as part of the slack message parsing to have a clear and consistent MessageEvent struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the eager implementation for fetching the channel name and username.
Add support for slash commands within CommandDefinition.
Add support for interactive events as part of the CommandDefinition.