Fix RuntimeError: dictionary changed size during iteration

[joemeister]

Description

This attempts to address situations where globals() changed during iteration.

    import httpagentparser
  File "/.virtualenv/lib/python3.6/site-packages/httpagentparser/__init__.py", line 647, in <module>
    detectorshub = DetectorsHub()
  File "/.virtualenv/lib/python3.6/site-packages/httpagentparser/__init__.py", line 21, in __init__
    self.registerDetectors()
  File "/.virtualenv/lib/python3.6/site-packages/httpagentparser/__init__.py", line 34, in registerDetectors
    detectors = [v() for v in globals().values() if DetectorBase in getattr(v, '__mro__', [])]
  File "/.virtualenv/lib/python3.6/site-packages/httpagentparser/__init__.py", line 34, in <listcomp>
    detectors = [v() for v in globals().values() if DetectorBase in getattr(v, '__mro__', [])]
RuntimeError: dictionary changed size during iteration

It occurred during start up of a multi-threaded Flask app.

Approach

Iterate a list copy of globals().values() instead.

[sfdye]

@shon what do you think?

[shon]

Thank you @sfdye

[sfdye]

While I have you, any chance we can cut a new release that includes this fix? Because our production is currently affected by the bug. Please let me know if you need any help with the chores.

[shon]

@sfdye here you go https://pypi.org/project/httpagentparser/1.8.5/ :)

[sfdye]

Wow you are amazing 🤩 thank you!

[shon]

@sfdye sorry here's the correct link https://pypi.org/project/httpagentparser/1.9.1/

[joemeister]

Thanks for the speedy response @shon !