Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuntimeError: dictionary changed size during iteration #85

Merged
merged 2 commits into from Jan 12, 2021
Merged

Fix RuntimeError: dictionary changed size during iteration #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a68d93f
Shallow copy globals()
joemeister Jan 12, 2021
b19748d
Change to list
joemeister Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpagentparser/__init__.py
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ def __iter__(self):
return iter(self._known_types)

def registerDetectors(self):
detectors = [v() for v in globals().values() if DetectorBase in getattr(v, '__mro__', [])]
detectors = [v() for v in list(globals().values()) if DetectorBase in getattr(v, '__mro__', [])]
for d in detectors:
if d.can_register:
self.register(d)
Expand Down