Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic reporting core to Shuup (SHUUP-2085) #699

Merged
merged 4 commits into from Aug 12, 2016
Merged

Add basic reporting core to Shuup (SHUUP-2085) #699

merged 4 commits into from Aug 12, 2016

Conversation

Pikkupomo
Copy link
Contributor

@Pikkupomo Pikkupomo commented Aug 4, 2016

Add Total Sales report
Add Sales Report
Add Sales per Hour report
Move pdf tools from order printouts to shuup/utils
Testing: Cache prices when creating order with product

Refs SHUUP-2085

@Pikkupomo Pikkupomo changed the title Add basic reporting core to Shuup Add basic reporting core to Shuup (SHUUP-2085) Aug 4, 2016

def get_urls(self):
return [
admin_url("^reporting/$", "shuup.reporting.admin_module.views.ReportView", name="reporting.list")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add permissions

@tulimaki
Copy link
Contributor

tulimaki commented Aug 4, 2016

I would like to see this splitted a little. Maybe core, admin, and each reports separately. 1k lines changed in one commit is never a good idea.

@tulimaki
Copy link
Contributor

tulimaki commented Aug 4, 2016

As a suggestion I think better name for this app could be just reports. IMO it would be more in sync with the other apps in Shuup base.


class OrderReportMixin(object):
def get_objects(self):
return Order.objects.filter(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably filter cancelled orders or there should be option to remove cancelled orders from the report.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2147/
Test PASSed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2179/
Test PASSed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2181/
Test PASSed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2189/
Test FAILed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2191/
Test FAILed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2192/
Test FAILed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2194/
Test FAILed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2197/
Test PASSed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2199/
Test FAILed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2204/
Test FAILed.

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2205/
Test FAILed.

Refs SHUUP-2085
Add Sales Report
Add Sales Per Hour Report
Add Total Sales Report

Refs SHUUP-2085
@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2206/
Test FAILed.

@tulimaki
Copy link
Contributor

retest this please

@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/2207/
Test PASSed.

@tulimaki tulimaki merged commit 699e372 into shuup:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants