-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use last known location if GPS fails to sync #752
Use last known location if GPS fails to sync #752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this looks like a great start!
I added some comments on how to better fit the fp-ts model this project is using, would recommend to look at their docs too! https://gcanti.github.io/fp-ts/
About how to test, I would recommend to:
- remove the Location permission from the Expo app
- when the app launches, deny the location permission
- the piece of code you're modifying will then be called (you can put some console.logs while debugging)
I took your suggestions to make some changes and on my phone the functionality seems to behave as expected. Happy to make further adjustments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good at 1st glance! I'll also test on my phone.
Hey! Could you merge master into your branch? I believe the failing test is related to that.
Otherwise, I tested on my phone, it works well! Great job! |
…save_last_location
bc01ab7
to
2d3d536
Compare
Thanks again, @HaramanJohal! |
No problem @amaurymartiny thanks for teaching me something about functional typescript |
There's a few things I'm not yet sure about so I'm happy to discuss and make corrections here
Closes: #727