Small code quality tweaks

shootphp · Dec 8, 2017 · c9493eb · c9493eb
1 parent 6c4ac70
commit c9493eb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 12 deletions.
diff --git a/src/Middleware/PresenterMiddleware.php b/src/Middleware/PresenterMiddleware.php
@@ -42,7 +42,7 @@ public function process(View $view, Context $context, callable $next): View
     {
         $presentationModel = $view->getPresentationModel();
 
-        if (!$this->hasData($presentationModel) && $presentationModel instanceof HasPresenterInterface) {
+        if ($presentationModel instanceof HasPresenterInterface && !$this->hasData($presentationModel)) {
             $presenter = $this->loadPresenter($presentationModel);
             $presentationModel = $presenter->present($context, $presentationModel);
             $view = $view->withPresentationModel($presentationModel);

diff --git a/src/PresentationModel.php b/src/PresentationModel.php
@@ -52,17 +52,11 @@ final public function withVariables(array $variables): self
      */
     private function setVariables(array $variables)
     {
-        if (static::class === self::class) {
-            foreach ($variables as $variable => $value) {
-                if (is_string($variable)) {
-                    $this->$variable = $value;
-                }
-            }
-        } else {
-            foreach ($variables as $variable => $value) {
-                if (property_exists($this, $variable)) {
-                    $this->$variable = $value;
-                }
+        $isGeneric = static::class === self::class;
+
+        foreach ($variables as $variable => $value) {
+            if (is_string($variable) && ($isGeneric || property_exists($this, $variable))) {
+                $this->$variable = $value;
             }
         }
     }

diff --git a/src/View.php b/src/View.php
@@ -5,6 +5,9 @@
 
 use InvalidArgumentException;
 
+/**
+ * A view is the visual representation of a model.
+ */
 final class View
 {
     /** @var callable */

diff --git a/tests/Fixtures/ProductPresentationModel.php b/tests/Fixtures/ProductPresentationModel.php
@@ -10,8 +10,10 @@ final class ProductPresentationModel extends PresentationModel implements HasPre
 {
     /** @var bool */
     protected $on_stock = false;
+
     /** @var string */
     protected $product_name = '';
+
     /** @var int */
     protected $stock_quantity = 0;