Bumps twig to 2.12/3.0 for PHP 7.4 compatibility #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@victorwelling Would you have time to take a look at this one? |
|
@Intrepidity Apologies, it appears I don't get notifications for new PR's. Would you be OK with including v3.0 of Twig as well? |
|
I didn't test it with 3.0, not sure how many internals changed that would make it not work with shoot. I'll take some time to test it and get back to you :) |
|
I've been testing Shoot with v3.0 since it's been in development, so it should be fine 😬 |
|
I think we should then stick with |
Intrepidity
changed the title
|
Changed to 2.12 and 3.0 |
|
@Intrepidity: Shoot v3.2 is now available. Happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.12 fixes an issue where array_key_exists is used on objects, which generates an E_DEPRECATED level error in PHP 7.4