PI-10295 ENGAGE: Product Slider Widget sort order doesn't work

shopgate · Mar 23, 2021 · 3d8eac1 · 3d8eac1
1 parent ed5ba0c
commit 3d8eac1
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/themes/theme-gmd/widgets/selectors.js b/themes/theme-gmd/widgets/selectors.js
@@ -1,4 +1,5 @@
 import { createSelector } from 'reselect';
+import { SORT_PRICE_ASC, SORT_PRICE_DESC } from '@shopgate/engage/core';
 import { generateResultHash } from '@shopgate/pwa-common/helpers/redux';
 import { transformDisplayOptions } from '@shopgate/pwa-common/helpers/data';
 import { getSortOrder } from '@shopgate/pwa-common/selectors/history';
@@ -122,8 +123,20 @@ export const getProductsResultWithHash = createSelector(
 export const getProductsResultsWithIds = (state, type, params, id) => {
   const currentSort = getSortOrder(state);
   const { value: productIds = [], sort = currentSort } = params || {};
-  const products = productIds.map(productId => getProduct(state, { productId })).filter(Boolean);
+  let products = productIds.map(productId => getProduct(state, { productId })).filter(Boolean);
   const hash = getResultHash(state, type, params, id);
+
+  const transformedSort = transformDisplayOptions(sort);
+
+  // Sort by price since fetch by id does not support sorting
+  if (transformedSort === SORT_PRICE_ASC) {
+    products = products.sort((p1, p2) => p1.price.unitPrice - p2.price.unitPrice);
+  }
+
+  if (transformedSort === SORT_PRICE_DESC) {
+    products = products.sort((p1, p2) => p2.price.unitPrice - p1.price.unitPrice);
+  }
+
   return {
     products,
     totalProductCount: products.length,

diff --git a/themes/theme-ios11/widgets/selectors.js b/themes/theme-ios11/widgets/selectors.js
@@ -1,4 +1,5 @@
 import { createSelector } from 'reselect';
+import { SORT_PRICE_ASC, SORT_PRICE_DESC } from '@shopgate/engage/core';
 import { generateResultHash } from '@shopgate/pwa-common/helpers/redux';
 import { transformDisplayOptions } from '@shopgate/pwa-common/helpers/data';
 import { getSortOrder } from '@shopgate/pwa-common/selectors/history';
@@ -122,8 +123,19 @@ export const getProductsResultWithHash = createSelector(
 export const getProductsResultsWithIds = (state, type, params, id) => {
   const currentSort = getSortOrder(state);
   const { value: productIds = [], sort = currentSort } = params || {};
-  const products = productIds.map(productId => getProduct(state, { productId })).filter(Boolean);
+  let products = productIds.map(productId => getProduct(state, { productId })).filter(Boolean);
   const hash = getResultHash(state, type, params, id);
+
+  const transformedSort = transformDisplayOptions(sort);
+
+  // Sort by price since fetch by id does not support sorting
+  if (transformedSort === SORT_PRICE_ASC) {
+    products = products.sort((p1, p2) => p1.price.unitPrice - p2.price.unitPrice);
+  }
+
+  if (transformedSort === SORT_PRICE_DESC) {
+    products = products.sort((p1, p2) => p2.price.unitPrice - p1.price.unitPrice);
+  }
   return {
     products,
     totalProductCount: products.length,