Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filter attribute deselection from within the filters page #303

Merged

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Oct 9, 2018

Description

It's now possible again to deselect all filter attribute values from within the filters page. Before is wasn't possible to deselect those attribute values which where already set when the filter page was entered.

Type of change

  • [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

How to test it

  • open the filter page from a product list (e.g. a category)
  • select one or more filter attribute values and apply the filters
  • open the filter page again and deselect all attribute values

@fkloes fkloes added the bug Something isn't working label Oct 9, 2018
@fkloes fkloes self-assigned this Oct 9, 2018
@fkloes fkloes changed the base branch from develop to PWA-327-Exchange-Router October 9, 2018 08:34
@devbucket devbucket merged commit f897ada into PWA-327-Exchange-Router Oct 9, 2018
@devbucket devbucket deleted the PWA-1003-filter-deselection-not-possible branch October 9, 2018 09:36
SG-Noxoreos pushed a commit that referenced this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants