Review props are not causing unnecessary updates in the component. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1143
💛 - Coveralls |
| this.setState(prevState => ({ | ||
| productId, | ||
| ...review, | ||
| ...!prevState[FIELD_NAME_AUTHOR] && { [FIELD_NAME_AUTHOR]: (author || authorName) }, |
There was a problem hiding this comment.
Can you please make this a little more digestible
richardgorman
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since every action in the write-review-form was causing the incoming props to change, one would see previous form state when submitting a changed review. This is now prevented by protecting props from being populated if they are not changed.
Type of change
Please add an "x" into the option that is relevant:
How to test it
Write a new review in the Product Detail Page, submit it and the try to change it again. The previous state of the review shouldn't be visible when submitting the form.