Products are now requested with the exact price range from the filters #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the getProducts pipeline is now called with the price range that is shown to the user
| return Object.keys(activeFilters).reduce((result, filterId) => { | ||
| const filter = activeFilters[filterId]; | ||
|
|
||
| if (filterId === 'display_amount') { |
There was a problem hiding this comment.
I think that here it would be better to check for a range filter type.
…-requests-with-price-range
Pull Request Test Coverage Report for Build 1170
💛 - Coveralls |
richardgorman
approved these changes
Oct 12, 2018
… github.com:shopgate/pwa into PWA-1098-fix-get-products-requests-with-price-range
richardgorman
deleted the
PWA-1098-fix-get-products-requests-with-price-range
branch
SG-Noxoreos
pushed a commit
that referenced
this pull request
Oct 30, 2018
…gories Pwa 475 error handling for categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticked fixes an issue where customers filtered products in category or search by price, but the request wasn't dispatched with the exact range that the user had picked. That caused that the filtered products lists didn't contain all available products within the price range which the user decided for.
Type of change
Please add an "x" into the option that is relevant:
How to test it