Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove continue shopping button in iOS #340

Merged
merged 8 commits into from
Oct 30, 2018
Merged

Remove continue shopping button in iOS #340

merged 8 commits into from
Oct 30, 2018

Conversation

richardgorman
Copy link
Contributor

@richardgorman richardgorman commented Oct 24, 2018 •
edited by reneeichhorn
Loading

Description

Continue Shopping buttons in iOS are removed

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@richardgorman richardgorman changed the title Pwa 1148 remove continue shopping button in i os Remove continue shopping button in iOS Oct 24, 2018
@richardgorman richardgorman self-assigned this Oct 24, 2018
@richardgorman richardgorman added the enhancement New feature or request label Oct 24, 2018
@coveralls
Copy link

coveralls commented Oct 24, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1294

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 46.141%
Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-ios11/components/TabBar/subscriptions.js 10 12 83.33%
Totals Coverage Status
Change from base Build 1291: 0.07%
Covered Lines: 4800
Relevant Lines: 9789
💛 - Coveralls

@fkloes fkloes merged commit 17d1336 into PWA-327-Exchange-Router Oct 30, 2018
@fkloes fkloes deleted the PWA-1148-Remove-Continue-Shopping-button-in-iOS branch October 30, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkloes fkloes fkloes approved these changes

Assignees

@richardgorman richardgorman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardgorman @coveralls @fkloes @reneeichhorn