iOS widget headline styling is now consistent #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richardgorman
commented
Oct 31, 2018
richardgorman
commented
- [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
- [ ] New Feature 🚀 (non-breaking change which adds functionality)
- [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
- [ ] Polish 💅 (Just some cleanups)
- [ ] Docs 📝 (Changes in the documentations)
- [ ] Internal 🏠 Only relates to internal processes.
Pull Request Test Coverage Report for Build 1362
💛 - Coveralls |
fkloes
added a commit
that referenced
this pull request
Nov 1, 2018
PWA-73 - removed onload command from themes, moved to appDidStart sub…
…o PWA-1167-iOS-widget-headline-styling-is-inconsistent
fkloes
requested changes
Nov 1, 2018
| @@ -171,7 +171,7 @@ class ProductsWidget extends Component { | |||
|
|
|||
| return ( | |||
| <div {...isList ? { className: styles.listView } : {}}> | |||
| <Headline text={headline} /> | |||
| <Headline tag="h3" text={headline} /> | |||
There was a problem hiding this comment.
The headlines are still not consistent. The headline of this widget now has a font-size of 22px and a margin of 12px at top and bottom.
The other widget headlines have a font-size of 18px and margins of 16px - some explicitly at the top, some at the bottom.
…ine-styling-is-inconsistent
…ine-styling-is-inconsistent
…ine-styling-is-inconsistent
fkloes
approved these changes
Nov 2, 2018
fkloes
deleted the
PWA-1167-iOS-widget-headline-styling-is-inconsistent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.