-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a click handler to the AppBar.Title component #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richardgorman
commented
Nov 28, 2018
- [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
- [ ] New Feature 🚀 (non-breaking change which adds functionality)
- [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
- [ ] Polish 💅 (Just some cleanups)
- [ ] Docs 📝 (Changes in the documentations)
- [ ] Internal 🏠 Only relates to internal processes.
…-term-cannot-be-edited
fkloes
requested changes
Nov 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to the current production apps some things have changed
- when one opens the search bar with an active search term and submits, a new history entry is created. This shouldn't happen.
- when one updates the search term, the search result page should be replaced, instead of creating a new history entry
Pull Request Test Coverage Report for Build 1712
💛 - Coveralls |
…-term-cannot-be-edited
fkloes
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.