Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a click handler to the AppBar.Title component #430

Merged
merged 8 commits into from
Dec 6, 2018

Conversation

richardgorman
Copy link
Contributor

  • [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@richardgorman richardgorman added the bug Something isn't working label Nov 28, 2018
@richardgorman richardgorman self-assigned this Nov 28, 2018
Copy link
Collaborator

@fkloes fkloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to the current production apps some things have changed

  • when one opens the search bar with an active search term and submits, a new history entry is created. This shouldn't happen.
  • when one updates the search term, the search result page should be replaced, instead of creating a new history entry

@coveralls
Copy link

coveralls commented Dec 3, 2018

Pull Request Test Coverage Report for Build 1712

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 47.133%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-gmd/components/Search/connector.js 0 3 0.0%
Totals Coverage Status
Change from base Build 1706: 0.007%
Covered Lines: 4843
Relevant Lines: 9704

💛 - Coveralls

@fkloes fkloes merged commit e4edbcb into v6.0.1 Dec 6, 2018
@fkloes fkloes deleted the PWA-1258-Search-term-cannot-be-edited branch December 6, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants