Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added inset padding to Material AppBar. AppBar in GMD now renders outside of View content #433

Merged
merged 6 commits into from
Nov 30, 2018
Merged

Added inset padding to Material AppBar. AppBar in GMD now renders outside of View content #433

merged 6 commits into from
Nov 30, 2018

Conversation

richardgorman
Copy link
Contributor

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ x ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@richardgorman richardgorman added the enhancement New feature or request label Nov 29, 2018
@richardgorman richardgorman self-assigned this Nov 29, 2018
fkloes
fkloes requested changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@fkloes fkloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The PaymentBar doesn't use the bottom inset yet
  • Footer area insets don't seem to be considered at all (pages / snackbar / shop more buttons in cart and favorite list)
  • Search suggestions are not scrollable

@fkloes fkloes merged commit 46ffe57 into v6.2.0 Nov 30, 2018
@fkloes fkloes deleted the PWA-804-Allow-GMD-theme-to-run-on-iOS-device branch November 30, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkloes fkloes fkloes approved these changes

Assignees

@richardgorman richardgorman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardgorman @fkloes