Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detector fix #454

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Detector fix #454

merged 1 commit into from
Dec 5, 2018

Conversation

sznowicki
Copy link
Contributor

Description

Detector can be an empty object, when this module is imported in an environment different than a browser it throws

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

How to test it

Try to unit test shopgate-ext-upsell outside of monorepository with removed mocks folder

@sznowicki
PWA-1416 - detector can be an empty object, when this module is impor…
dbb1911 
…ted in an environment different than a browser it throws
@sznowicki sznowicki added the bug Something isn't working label Dec 5, 2018
@sznowicki sznowicki self-assigned this Dec 5, 2018
@richardgorman richardgorman merged commit d44e51e into v6.0.1 Dec 5, 2018
@richardgorman richardgorman deleted the PWA-1416-detector-error-fix branch December 5, 2018 10:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1685

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 47.098%
Totals Coverage Status
Change from base Build 1681: 0.02%
Covered Lines: 4843
Relevant Lines: 9714
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardgorman richardgorman richardgorman approved these changes

Assignees

@sznowicki sznowicki

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sznowicki @coveralls @richardgorman