Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing extensibility improvements #470

Merged
merged 22 commits into from
Dec 11, 2018

Conversation

richardgorman
Copy link
Contributor

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ x ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@richardgorman richardgorman added the enhancement New feature or request label Dec 11, 2018
@richardgorman richardgorman self-assigned this Dec 11, 2018
@coveralls
Copy link

coveralls commented Dec 11, 2018

Pull Request Test Coverage Report for Build 1749

  • 4 of 44 (9.09%) changed or added relevant lines in 15 files are covered.
  • 55 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.7%) to 46.802%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/common/context/index.js 0 1 0.0%
libraries/common/selectors/router.js 3 4 75.0%
libraries/common/subscriptions/helpers/handleLinks.js 0 1 0.0%
themes/theme-gmd/pages/subscriptions.js 0 1 0.0%
libraries/common/actions/router/routeDidPop.js 0 3 0.0%
libraries/common/actions/router/routeDidPush.js 0 3 0.0%
libraries/common/actions/router/routeDidReplace.js 0 3 0.0%
libraries/common/actions/router/routeDidReset.js 0 3 0.0%
libraries/common/actions/router/routeWillPop.js 0 3 0.0%
libraries/common/actions/router/routeWillPush.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/tracking/selectors/page.js 1 0.0%
libraries/common/selectors/router.js 1 68.09%
libraries/core/commands/openPage.js 2 0.0%
libraries/core/commands/showTab.js 2 57.14%
libraries/common/subscriptions/helpers/handleLinks.js 19 52.21%
libraries/common/subscriptions/router.js 30 36.54%
Totals Coverage Status
Change from base Build 1747: -0.7%
Covered Lines: 4806
Relevant Lines: 9667

💛 - Coveralls

@devbucket devbucket merged commit 893aeb1 into v6.1.0 Dec 11, 2018
@devbucket devbucket deleted the PWA-1458-Routing-extensibility-improvements branch December 11, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants