Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always render RATING_* portals on PDP #506

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Always render RATING_* portals on PDP #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions themes/theme-gmd/pages/Product/components/Header/components/Rating/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,20 @@ const scrollToRating = () => {
* @param {Object} props The component props.
* @return {JSX}
*/
const Rating = ({ rating }) => {
if (!appConfig.hasReviews || !rating || !rating.count) {
return null;
}

return (
<Fragment>
<Portal name={PRODUCT_RATING_BEFORE} />
<Portal name={PRODUCT_RATING}>
const Rating = ({ rating }) => (
<Fragment>
<Portal name={PRODUCT_RATING_BEFORE} />
<Portal name={PRODUCT_RATING}>
{appConfig.hasReviews && rating && rating.count &&
<div className={container} onClick={scrollToRating} role="link" aria-hidden>
<RatingStars value={rating.average} display="big" />
<RatingCount count={rating.count} prominent />
</div>
</Portal>
<Portal name={PRODUCT_RATING_AFTER} />
</Fragment>
);
};
}
</Portal>
<Portal name={PRODUCT_RATING_AFTER} />
</Fragment>
);

Rating.propTypes = {
rating: PropTypes.shape(),
Expand Down
24 changes: 10 additions & 14 deletions themes/theme-ios11/pages/Product/components/Header/components/Rating/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,20 @@ const scrollToRating = () => {
* @param {Object} props The component props.
* @return {JSX}
*/
const Rating = ({ rating }) => {
if (!appConfig.hasReviews || !rating || !rating.count) {
return null;
}

return (
<Fragment>
<Portal name={PRODUCT_RATING_BEFORE} />
<Portal name={PRODUCT_RATING}>
const Rating = ({ rating }) => (
<Fragment>
<Portal name={PRODUCT_RATING_BEFORE} />
<Portal name={PRODUCT_RATING}>
{appConfig.hasReviews && rating && rating.count &&
<div className={container} onClick={scrollToRating} role="link" aria-hidden>
<RatingStars value={rating.average} display="big" />
<RatingCount count={rating.count} prominent />
</div>
</Portal>
<Portal name={PRODUCT_RATING_AFTER} />
</Fragment>
);
};
}
</Portal>
<Portal name={PRODUCT_RATING_AFTER} />
</Fragment>
);

Rating.propTypes = {
rating: PropTypes.shape(),
Expand Down