Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed more menu styling and aligned theme ios11 and gmd designs to be more compatible #507

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

SG-Noxoreos
Copy link
Contributor

Changed ios11 theme more menu to split out the logout button from the user menu, so extensions can add an own user menu without handling design conflicts between ios11 and gmd themes. Changed item styling, so it looks better when an item group does not require a headline.

Description

Please include a summary of the change. Please also include relevant motivation and context.

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

…n from the user menu, so extensions can add an own user menu without handling design conflicts between ios11 and gmd themes. Changed item styling, so it looks better when an item group does not require a headline.
@SG-Noxoreos SG-Noxoreos added the enhancement New feature or request label Jan 23, 2019
@coveralls
Copy link

coveralls commented Jan 23, 2019

Pull Request Test Coverage Report for Build 1898

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 46.837%

Totals Coverage Status
Change from base Build 1897: 0.004%
Covered Lines: 4951
Relevant Lines: 9907

💛 - Coveralls

@alexbridge alexbridge merged commit 19a9e22 into v6.1.0 Jan 24, 2019
@alexbridge alexbridge deleted the PWA-1580 branch January 24, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants