Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ImageSliderWidget update when the startpage was updated #520

Merged
merged 4 commits into from
Feb 4, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Feb 4, 2019

Description

This ticket is about to fix and issue with the ImageSliderWidget which didn't update properly, when the related page config was updated.
This issue caused broken images on a persisted startpage, when the image URLs where outdated.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

How to test it

  • configure an ImageSliderWidget on your startpage with at least two images
  • open the PWA startpage
  • change the configuration / order of the widget
  • reload the PWA startpage
    The startpage should reflect the updated widget configuration after the getPageConfig for the startpage came in.

@fkloes fkloes added the bug Something isn't working label Feb 4, 2019
@fkloes fkloes self-assigned this Feb 4, 2019
@coveralls
Copy link

coveralls commented Feb 4, 2019

Pull Request Test Coverage Report for Build 1937

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 46.847%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-ios11/pages/Product/components/AddToCartBar/components/CartItemsCount/style.js 0 1 0.0%
Totals Coverage Status
Change from base Build 1936: -0.003%
Covered Lines: 4954
Relevant Lines: 9911

💛 - Coveralls

@devbucket devbucket merged commit b7882e4 into v6.1.0 Feb 4, 2019
@devbucket devbucket deleted the PWA-1642-broken-images-on-startpage branch February 4, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants