Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the NestedCategoryFilterWidget #530

Merged
merged 10 commits into from
Feb 12, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Feb 8, 2019

Description

This ticket is about to implement the nested category filter widget for iOS and GMD.
It also improves the "selected" state visualization of option and characteristic pickers on the PDP.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@fkloes fkloes added the enhancement New feature or request label Feb 8, 2019
@fkloes fkloes self-assigned this Feb 8, 2019
@coveralls
Copy link

coveralls commented Feb 8, 2019

Pull Request Test Coverage Report for Build 1989

  • 45 of 48 (93.75%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 47.255%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-ios11/pages/Product/components/Characteristics/Characteristic/components/SheetItem/style.js 0 3 0.0%
Totals Coverage Status
Change from base Build 1988: 0.4%
Covered Lines: 5041
Relevant Lines: 10004

💛 - Coveralls

@alexbridge alexbridge merged commit 0692916 into v6.3.0 Feb 12, 2019
@alexbridge alexbridge deleted the PWA-1581-nested-category-filter branch February 12, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants