Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check issues of Browser Connector with Cypress Tests #536

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Conversation

alexbridge
Copy link
Contributor

Description

Check issues of Browser Connector with Cypress Tests

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ X ] Internal 🏠 Only relates to internal processes.

How to test it

Please describe here any specialty that the tester should be aware of.

@alexbridge alexbridge added the enhancement New feature or request label Feb 13, 2019
@alexbridge alexbridge self-assigned this Feb 13, 2019
@coveralls
Copy link

coveralls commented Feb 14, 2019

Pull Request Test Coverage Report for Build 2020

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.999%

Totals Coverage Status
Change from base Build 2016: 0.0%
Covered Lines: 4995
Relevant Lines: 9975

💛 - Coveralls

Copy link
Collaborator

@fkloes fkloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the iOS theme tests don't work anymore, since they are running with the GMD theme.
Additionally there where some files created on my machine, which where not added to git yet. So i assume that they need to be added to the .gitignore

@fkloes fkloes merged commit 871fc9b into v6.2.0 Feb 15, 2019
@fkloes fkloes deleted the PWA-1687 branch February 15, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants