Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sentry.io for javascript error logging for engage app #551

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

alexbridge
Copy link
Contributor

Description

Implement sentry.io for javascript error logging for engage app

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ X ] Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the enhancement New feature or request label Feb 26, 2019
@alexbridge alexbridge self-assigned this Feb 26, 2019
@coveralls
Copy link

coveralls commented Feb 26, 2019

Pull Request Test Coverage Report for Build 2085

  • 3 of 56 (5.36%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 47.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/common/components/ErrorBoundary/connector.js 1 2 50.0%
themes/theme-gmd/pages/subscribers.js 0 1 0.0%
themes/theme-ios11/pages/subscribers.js 0 1 0.0%
libraries/common/subscriptions/error.js 0 50 0.0%
Totals Coverage Status
Change from base Build 2084: -0.2%
Covered Lines: 5064
Relevant Lines: 10081

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2072

  • 2 of 57 (3.51%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 47.111%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-gmd/pages/subscribers.js 0 1 0.0%
themes/theme-ios11/pages/subscribers.js 0 1 0.0%
libraries/common/components/ErrorBoundary/connector.js 0 4 0.0%
libraries/common/subscriptions/error.js 0 49 0.0%
Totals Coverage Status
Change from base Build 2071: -0.2%
Covered Lines: 5058
Relevant Lines: 10078

💛 - Coveralls

@devbucket devbucket merged commit 4f77ecd into v6.X Feb 27, 2019
@devbucket devbucket deleted the PWA-1725 branch February 27, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants