Show Barcode Scan results (basic) #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkloes
requested changes
Mar 15, 2019
| }); | ||
|
|
||
| it('should show modal when products not found', async () => { | ||
| fetchProductsByQuery.mockReturnValue(Promise.resolve({ |
There was a problem hiding this comment.
You can simplify this by replacing .mockReturnValue(Promise.resolve({})) with .mockResolvedValue({}) - same for the other occurrences.
| ] = subscribe.mock.calls; | ||
| }); | ||
|
|
||
| it('should initialize subscriptions', () => { |
There was a problem hiding this comment.
Could you please split the tests by adding two additional describe blocks - one for each subscription.
| fetchProductsByQuery.mockReturnValue(Promise.resolve({ | ||
| totalProductCount: 0, | ||
| })); | ||
| showModal.mockImplementation(options => Promise.resolve(options)); |
There was a problem hiding this comment.
Why didn't you add the mock implementation to the mock creation - like you do it for the other mocks.
| import { SCANNER_SUCCESS } from '../constants'; | ||
|
|
||
| /** @type {Observable} */ | ||
| export const scanSuccess$ = main$ |
There was a problem hiding this comment.
As discussed please rename scanSuccess$ to scanFinished$.
fkloes
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show Barcode Scan results (basic)