Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coupon + product to cart when QR code is scanned #603

Merged
merged 4 commits into from
Apr 5, 2019
Merged

Add coupon + product to cart when QR code is scanned #603

merged 4 commits into from
Apr 5, 2019

Conversation

alexbridge
Copy link
Contributor

@alexbridge alexbridge commented Apr 5, 2019 •
edited
Loading

Description

Add coupon + product to cart when QR code is scanned

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the bug Something isn't working label Apr 5, 2019
@alexbridge alexbridge self-assigned this Apr 5, 2019
@coveralls
Copy link

coveralls commented Apr 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2359

  • 15 of 29 (51.72%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 50.229%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/commerce/scanner/actions/handleQrCode.js 5 6 83.33%
libraries/commerce/cart/subscriptions/index.js 4 17 23.53%
Files with Coverage Reduction New Missed Lines %
libraries/commerce/scanner/actions/handleQrCode.js 5 85.0%
Totals Coverage Status
Change from base Build 2356: -0.04%
Covered Lines: 5576
Relevant Lines: 10524
💛 - Coveralls

@fkloes fkloes merged commit 281cd5e into v6.4.0 Apr 5, 2019
@fkloes fkloes deleted the PWA-1809 branch April 5, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkloes fkloes fkloes approved these changes

Assignees

@alexbridge alexbridge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexbridge @coveralls @fkloes