Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended the scanner event listeners to register for specific payload formats #605

Closed
wants to merge 2 commits into from

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Apr 5, 2019

Description

This ticket extends the ScannerEventListener class with format whitelists for scanner payload. If instantiated with such is list, the handler will only be invoked, when it supports the format of scanner payload.

Type of change

  • Bug Fix 馃悰 (non-breaking change which fixes an issue)
  • Enhancement 馃殌 (non-breaking change which adds functionality)
  • Breaking Change 馃挜 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 馃拝 (Just some cleanups)
  • Internal 馃彔 Only relates to internal processes.

- it's now possible to register handlers which are only invoked, when a code with specific formats where scanned
@fkloes fkloes added bug Something isn't working enhancement New feature or request labels Apr 5, 2019
@fkloes fkloes self-assigned this Apr 5, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2351

  • 22 of 22 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 51.023%

Totals Coverage Status
Change from base Build 2338: 0.07%
Covered Lines: 5741
Relevant Lines: 10638

馃挍 - Coveralls

@alexbridge alexbridge changed the base branch from v6.X to v6.4.0 April 5, 2019 13:42
@alexbridge alexbridge changed the base branch from v6.4.0 to v6.X April 5, 2019 13:43
@fkloes fkloes closed this Apr 5, 2019
@fkloes fkloes deleted the PWA-1827-scanner-freeze branch April 5, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants