Fixed secure config writer to correctly merge arrays #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrays without creating duplicates. Implemented usage of custom NMA config on top of already existing configs.
… are merged correctly using the theme-config extension. Renamed config property to match `theme`. Raised version number of the theme-config extension to `1.0.1`
fkloes
requested changes
Jun 6, 2019
…Deep` correctly handle merges of array containing scalar types. Added unit tests for `assignObjectDeep` helper function. Also split NMA theme configs into themeIos and themeGmd.
…ble or disable mock data.
…ckwards compatibility.
fkloes
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed secure config writer to correctly merge arrays using an array item comparator
Type of change