Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make modal window title translatable with parameters #698

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Make modal window title translatable with parameters #698

merged 2 commits into from
Jun 14, 2019

Conversation

alexbridge
Copy link
Contributor

Description

Make modal window title translatable with parameters.

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the enhancement New feature or request label Jun 13, 2019
@alexbridge alexbridge self-assigned this Jun 13, 2019
@SG-Noxoreos SG-Noxoreos merged commit 2ea7f57 into v6.7.0 Jun 14, 2019
@SG-Noxoreos SG-Noxoreos deleted the PWA-2018-dialog-title-i18n branch June 14, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SG-Noxoreos SG-Noxoreos SG-Noxoreos approved these changes

Assignees

@alexbridge alexbridge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexbridge @SG-Noxoreos