Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed shopify-webcheckout url logic to accept a full domain over the alias for the web-login #713

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

SG-Noxoreos
Copy link
Contributor

Description

Changed shopify-webcheckout url logic to accept a full domain over the alias for the web-login.

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

See ticket comments for test instructions.

@SG-Noxoreos SG-Noxoreos added the bug Something isn't working label Jun 27, 2019
@SG-Noxoreos SG-Noxoreos self-assigned this Jun 27, 2019
@alexbridge alexbridge merged commit 685eb18 into v6.5.3 Jun 28, 2019
@alexbridge alexbridge deleted the PWA-2080-add-shopify-domain-config-for-web-login branch June 28, 2019 06:52
@SG-Noxoreos SG-Noxoreos changed the title Changed shopify-webcheckout url logic to accept a full domain over the alias for the web-login. Changed shopify-webcheckout url logic to accept a full domain over the alias for the web-login Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants