Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to access widget and page configs and settings outside of the react scope. #722

Merged

Conversation

SG-Noxoreos
Copy link
Contributor

@SG-Noxoreos SG-Noxoreos commented Jul 2, 2019

Description

  • Added functionality to access widget and page configs and settings outside of the react scope.
  • Refactored theme config accessors and added unit tests.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

…and rerouted the similarly named React hooks to use the new getters, rather than operation on the config directly.
…about what is needed and keep settings inheritance.
…plemented `getWidgetConfig` and `getWidgetSettings` access functions and rerouted the similarly named hooks to use these. Lastly exposed the new access functions to the library interface.
…, when a searched key does not exist to avoid mixing up actual settings and empty objects.
…ed when the given key doesn't exist anywhere and added unit tests for it.
…`getWidgetConfig` with different indexes (zero and undefined) to behave in the same way.
@SG-Noxoreos SG-Noxoreos self-assigned this Jul 2, 2019
@SG-Noxoreos SG-Noxoreos added the enhancement New feature or request label Jul 2, 2019
@devbucket devbucket merged commit f6f185c into v6.7.0 Jul 9, 2019
@devbucket devbucket deleted the PWA-2079-add-global-access-functionality-for-page-configs branch July 9, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants