Added functionality to access widget and page configs and settings outside of the react scope. #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and rerouted the similarly named React hooks to use the new getters, rather than operation on the config directly.
…about what is needed and keep settings inheritance.
…tter describe, what they do.
…plemented `getWidgetConfig` and `getWidgetSettings` access functions and rerouted the similarly named hooks to use these. Lastly exposed the new access functions to the library interface.
…ig` and provided unit tests for it.
…, when a searched key does not exist to avoid mixing up actual settings and empty objects.
…ed when the given key doesn't exist anywhere and added unit tests for it.
…Settings` unit tests.
…s set or defaulted to zero
…`getWidgetConfig` with different indexes (zero and undefined) to behave in the same way.
devbucket
suggested changes
Jul 3, 2019
devbucket
approved these changes
Jul 9, 2019
devbucket
deleted the
PWA-2079-add-global-access-functionality-for-page-configs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change