Changed Ellipsis component for an update of the react-dotdotdot module #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pinned react-dotdotdot to version 1.3.x - added useNativeClamp prop to the Dotdotdot component since its default value was changed to false in 1.3.0
SG-Noxoreos
approved these changes
Jul 5, 2019
SG-Noxoreos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
Ellipsiscomponent internally uses theReact-dotdotdotmodule. Within the latest version1.3.0its default value for theuseNativeClampprop changed fromtruetofalse.The presence of this prop causes, that various styles are applied to wrapped DOM-Elements, which prevent strings from breaking out of their box. Without them it happened, that vertical scrolling was suddenly possible on product list that include product names with long words.
The code change of this ticket explicitly sets the prop to
true. Additionally the module version is now pinned to 1.3.x.Type of change