Refactored favorites actions to use add and delete favorites pipelines instead of put #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove favorites to do a call to the respective pipelines.
…action types. adjusted tests
…s, added constant for fav sync buffer time, removed unused constants
aaron-martin
changed the title
added 4 commits
July 8, 2019 13:44
…en because the net result of all buffered actions is to do nothing the request action is not dispatched. It goes directly to dispatch idle.
…/github.com/shopgate/pwa into PWA-2094-engage-refactor-favorites-pipeline
…d requestSync action. Added supporting action creator and stream
…. Changed subscriptions to avoid unnecessary pipeline calls, when nothing would change. Removed manual backend error handling, because the PipelineManager handles them already.
…ription. Did some cleanup and also separated local limit error from the backend one to be clear about what actually happens.
…actor-favorites-pipeline
…await instead of promises. Added unit tests for addFavorites pipeline call.
…hey have been replaced earlier.
…xposed stream observable.
…emented subscription tests for the favorites feature.
…actions. Also switched the `addFavorites` import in the themes to import from `@shopgate/engage` now.
SG-Noxoreos
approved these changes
Jul 22, 2019
|
Cleaned up the PR by removing outdated comments. |
devbucket
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes the PWA use the shopgate.user.addFavorites and shopgate.user.deleteFavorites pipelines instead of the shopgate.user.putFavorites. All uses of the putFavoirtes pipeline are discontinued. This is an important change for integrations with the magento user extension. Magento does not have the same 100 favorites limitation that the legacy backend has. When using the magento user extension magento shoppers risk deleting favorites when they have more than 100 in their favorites list because of the use of the putFavorites pipeline. Moving to the use of the add and remove pipeline removes this risk.
Type of change
Please add an "x" into the option that is relevant:
How to test it
Add and remove items from the favorite list.