Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long product names are hyphened and cur off correctly in ProductGrid #777

Merged
merged 5 commits into from
Jul 19, 2019
Merged

Long product names are hyphened and cur off correctly in ProductGrid #777

merged 5 commits into from
Jul 19, 2019

Conversation

devbucket
Copy link
Contributor

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@devbucket devbucket added the bug Something isn't working label Jul 18, 2019
@devbucket devbucket self-assigned this Jul 18, 2019
alexbridge
alexbridge suggested changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@alexbridge alexbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Css hyphens: auto has no effect, when there is no lang attribute set to oicument. See Jira ticket for details

@alexbridge alexbridge merged commit da24901 into v6.7.0 Jul 19, 2019
@alexbridge alexbridge deleted the PWA-2122-product-list-long-name branch July 19, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbridge alexbridge alexbridge approved these changes

Assignees

@devbucket devbucket

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devbucket @alexbridge