Added functionality to determine geolocation coordinates #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added request class to fetch the geo coordinates from the device - moved camera permission logic to the engage package - added unified action determine one of the possible permissions - added grantCameraPermissions and grantGeolocationPermissions actions which use the unified one
devbucket
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticket introduces actions which simplify access to geolocation coordinates.
grantGeolocationPermissionscan be used to grant the appropriate app permissions.getGeolocationretrieves the current position of the user. When no permissions where granted yet, it will also prompt the user to enable location services.Both actions can be imported from
@shopgate/engage/core.Type of change
How to test it
Within the development environment you can't test everything all together, since the feature relies on the native browser geolocation functionality and needs an
httpsconnection. Since the development apps are served viahttp, you can only test the code which triggers the permission granting process. In chrome you can test the position determination when you opened Engage viahttp://localhostAdd this import e.g. to a subscription
import { getGeolocation } from '@shopgate/engage/core';and dispatch the action.