Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: accessibility for favorites buttons and favorites page #836

Merged
merged 5 commits into from
Sep 26, 2019

Conversation

alexbridge
Copy link
Contributor

Description

A11y: accessibility for favorites buttons and favorites page

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the enhancement New feature or request label Sep 24, 2019
@alexbridge alexbridge self-assigned this Sep 24, 2019
libraries/ui-shared/FavoritesButton/index.jsx Outdated Show resolved Hide resolved
@@ -112,12 +112,17 @@ class SnackBar extends Component {
style={props}
data-footer-inset-update-ignore="true"
>
<div className={styles.box} {...boxProps}>
<div
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Android the message is read like "Status. Removed from favorites. Undo. Removed from favorites". On iOS 12 it's like "Removed from favorites. Removed from favorites.".

I've talked with our PO, and she'd also like to have a voice feedback when a product was added to the list. So it might be better to extend the favorites subscriptions and utilize the broadcastLiveMessage functionality.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the favorites page on iOS the screen reader still reads the message twice. On e.g. category pages it works as expected.

On Android it's also still read twice. One message still reads "Undo".

@@ -112,12 +112,17 @@ class SnackBar extends Component {
style={props}
data-footer-inset-update-ignore="true"
>
<div className={styles.box} {...boxProps}>
<div
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the favorites page on iOS the screen reader still reads the message twice. On e.g. category pages it works as expected.

On Android it's also still read twice. One message still reads "Undo".

@fkloes fkloes merged commit 6ff87a2 into v6.9.0 Sep 26, 2019
@fkloes fkloes deleted the PWA-2155-a11y-favorites branch September 26, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants