-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y: accessibility for favorites buttons and favorites page #836
Conversation
@@ -112,12 +112,17 @@ class SnackBar extends Component { | |||
style={props} | |||
data-footer-inset-update-ignore="true" | |||
> | |||
<div className={styles.box} {...boxProps}> | |||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Android the message is read like "Status. Removed from favorites. Undo. Removed from favorites". On iOS 12 it's like "Removed from favorites. Removed from favorites.".
I've talked with our PO, and she'd also like to have a voice feedback when a product was added to the list. So it might be better to extend the favorites subscriptions and utilize the broadcastLiveMessage
functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the favorites page on iOS the screen reader still reads the message twice. On e.g. category pages it works as expected.
On Android it's also still read twice. One message still reads "Undo".
@@ -112,12 +112,17 @@ class SnackBar extends Component { | |||
style={props} | |||
data-footer-inset-update-ignore="true" | |||
> | |||
<div className={styles.box} {...boxProps}> | |||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the favorites page on iOS the screen reader still reads the message twice. On e.g. category pages it works as expected.
On Android it's also still read twice. One message still reads "Undo".
Description
A11y: accessibility for favorites buttons and favorites page
Type of change
Please add an "x" into the option that is relevant: