Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in the Swiper and Section components using hooks. #843

Merged
merged 8 commits into from
Oct 11, 2019

Conversation

devbucket
Copy link
Contributor

Description

Fixed a bug in the Swiper and Section components using hooks.

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

Please describe here any specialty that the tester should be aware of.

@devbucket devbucket added the bug Something isn't working label Oct 10, 2019
@devbucket devbucket self-assigned this Oct 10, 2019
@devbucket devbucket changed the base branch from v6.8.1 to v6.8.0 October 10, 2019 12:08
Copy link
Collaborator

@fkloes fkloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests

libraries/common/components/Swiper/index.jsx Outdated Show resolved Hide resolved
@fkloes fkloes merged commit 5714ef9 into v6.8.0 Oct 11, 2019
@fkloes fkloes deleted the PWA-2250-swiper-does-not-re-initialize branch October 11, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants