Fixed sort filter entries text color #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbridge
approved these changes
Jan 27, 2020
alexbridge
deleted the
PWA-2420-filters-white-font-on-white-background
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticket fixes a styling bug of the sort filter entries. When other filters where selected, the entries of the sort dropdown where not readable anymore, since their text color was white.
The bug was caused by a refactoring of the SelectBoxItem component where a
buttonelement was transformed into anli. Other than buttons li elements inherit the color of their parent elements which is white in the described situation.Type of change
How to test it
Configure a filter for a category or search results and open the sort order drop down. The text should be readable again.