Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplication of new array config entries on reference resolving. Further improved the config resolve algorithm to also support concatenated configs using references and custom text. #914

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Fixed duplication of new array config entries on reference resolving. Further improved the config resolve algorithm to also support concatenated configs using references and custom text. #914

merged 2 commits into from
Feb 7, 2020

Conversation

SG-Noxoreos
Copy link
Contributor

@SG-Noxoreos SG-Noxoreos commented Feb 6, 2020 •
edited
Loading

Description

Fixed duplication of new array config entries on reference resolving. Further improved the config resolve algorithm to also support concatenated configs using references and custom text.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

Add a custom theme setting which contains an error. The entries should not be duplicated anymore. Then use a reference like "textSize: $.typography.lineHeight.$em". This should then resolve to "textSize: 1.5em".

@SG-Noxoreos
PWA-2473: Fixed duplication of new config entries on reference resolv…
87fa033 
…ing. Also improved reference resolve algorithm to also support concatenated configs with custom text.
@SG-Noxoreos SG-Noxoreos added the bug Something isn't working label Feb 6, 2020
@SG-Noxoreos SG-Noxoreos self-assigned this Feb 6, 2020
@SG-Noxoreos SG-Noxoreos changed the title Fixed duplication of new config entries on reference resolving. Also improved config resolve algorithm to also support concatenated configs using references and custom text. Fixed duplication of new config entries on reference resolving. Further improved config resolve algorithm to also support concatenated configs using references and custom text. Feb 6, 2020
@SG-Noxoreos SG-Noxoreos changed the title Fixed duplication of new config entries on reference resolving. Further improved config resolve algorithm to also support concatenated configs using references and custom text. Fixed duplication of new config entries on reference resolving. Further improved the config resolve algorithm to also support concatenated configs using references and custom text. Feb 6, 2020
@SG-Noxoreos SG-Noxoreos changed the title Fixed duplication of new config entries on reference resolving. Further improved the config resolve algorithm to also support concatenated configs using references and custom text. Fixed duplication of new array config entries on reference resolving. Further improved the config resolve algorithm to also support concatenated configs using references and custom text. Feb 6, 2020
@fkloes fkloes merged commit 38cea1c into v6.12.0 Feb 7, 2020
@fkloes fkloes deleted the PWA-2473-config-resolver-improvement branch February 7, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkloes fkloes fkloes approved these changes

Assignees

@SG-Noxoreos SG-Noxoreos

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SG-Noxoreos @fkloes