Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ConversionTable to module functions #38

Closed
thegedge opened this issue Nov 30, 2016 · 3 comments
Closed

Convert ConversionTable to module functions #38

thegedge opened this issue Nov 30, 2016 · 3 comments
Milestone

Comments

@thegedge
Copy link
Contributor

ConversionTable makes no sense, but rather encapsulates a set of operations to create a Hash for unit conversion. Since it's not meant to stick around we should just stick to exposing a function.

@thegedge thegedge added this to the Version 2.0 milestone Nov 30, 2016
@kmcphillips
Copy link
Member

I'm pretty so so on this. It's just a small object to encapsulate a set of resolution operations, generating an output.

If you mean switching it from instantiation to module functions I'm ok with that.

@thegedge
Copy link
Contributor Author

If you mean switching it from instantiation to module functions I'm ok with that.

Yep, that's what I mean. If there's no need for polymorphism, procedural programming is a perfectly good paradigm 😄

I'll be sure to double check and make sure this won't cause any issues when it comes to testability, but I don't think it will.

@kmcphillips
Copy link
Member

No that should be good then. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants